IMPROVEMENT: Andy Piper fix to tempcal script #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
changed the title
amilcarlucas
force-pushed
the
master
branch
2 times, most recently
from
a56275f to
bb12266
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
5e892eb to
8399d49
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
amilcarlucas
force-pushed
the
master
branch
2 times, most recently
from
041fb58 to
46095ad
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
8399d49 to
87d0309
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
87d0309 to
f182273
Compare
andyp1per
approved these changes
Aug 4, 2024
amilcarlucas
force-pushed
the
master
branch
4 times, most recently
from
1a4bd94 to
df9f512
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
f182273 to
ae677f3
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
ae677f3 to
bfef6ad
Compare
|
@andyp1per did you talk with @tridge about this? Does he agree with this? |
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
bfef6ad to
7e87805
Compare
Test Results 2 files 2 suites 1m 41s ⏱️ Results for commit 4359fbb. ♻️ This comment has been updated with latest results. |
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
7e87805 to
208d284
Compare
amilcarlucas
force-pushed
the
andy_piper_tempcal_fix
branch
from
208d284 to
4359fbb
Compare
There was a problem hiding this comment.
PR Overview
This PR improves the tempcal script by adding an extra condition to control IMU processing in the IMUfit loop.
- Introduces an additional check (c.enable[imu] == 2) to skip processing based on the enable state.
- Adjusts the control flow in the IMUfit function accordingly.
Reviewed Changes
| File | Description |
|---|---|
| ardupilot_methodic_configurator/tempcal_imu.py | Adds condition to bypass processing when c.enable[imu] equals 2. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
ardupilot_methodic_configurator/tempcal_imu.py:374
- Ensure that c.enable[imu] is properly initialized for every imu index before checking if it equals 2 to avoid potential index errors.
if stop_capture[imu] or c.enable[imu] == 2:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of ArduPilot/ardupilot#27294